[PATCH] D120357: [llvm-nm][refactor] add helper function to print out the object file name, archive name, architecture name

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1864
+
+static void dumpSymbolNamesFromObject(SymbolicFile &Obj, bool PrintName,
+                                      bool PrintObjectNameInfo,
----------------
Try `const SymbolicFile &Obj` and fix some non-const references in the body.


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1853
+                                 StringRef ArchitectureName = {},
+                                 StringRef OjectFileName = {}) {
+  outs() << "\n";
----------------
MaskRay wrote:
> 
Not fixed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120357/new/

https://reviews.llvm.org/D120357