[PATCH] D120370: [AMDGPU] Fix combined MMO in load-store merge

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 23 09:40:52 PST 2022


rampitec added a comment.

In D120370#3340678 <https://reviews.llvm.org/D120370#3340678>, @foad wrote:

>> The thing I have written in the test might be mannered, but this is exactly what I meant for the testing purposes: align is 8, basealign is 4, offset to it is 4,
>
> MachineMemOperand **cannot** represent that information. It only stores basealign explicitly, and it computes align on demand from basealign and offset. See MachineMemOperand::getAlign().

Hm... Indeed. But then 'align' itself shall not probably accepted by the MIR parser at all? Only the basealign is a real input?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120370/new/

https://reviews.llvm.org/D120370



More information about the llvm-commits mailing list