[PATCH] D119917: [Support] Add CSKY target parser and attributes parser

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 23 07:28:36 PST 2022


DavidSpickett added inline comments.


================
Comment at: llvm/unittests/Support/CSKYAttributeParserTest.cpp:36
+       // uint32_t = VendorHeaderSize + TagHeaderSize + ContentsSize.
+       << (uint8_t)16 << (uint8_t)0 << (uint8_t)0 << (uint8_t)0
+       // CurrentVendor.
----------------
Thanks for adding the comments, I would just do as clang-format asks here. With the comments to denote each section it makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119917/new/

https://reviews.llvm.org/D119917



More information about the llvm-commits mailing list