[PATCH] D120370: [AMDGPU] Fix combined MMO in load-store merge

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 23 01:40:50 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:665-666
 
-// This function assumes that \p A and \p B have are identical except for
+// This function assumes that \p A and \p B are identical except for
 // size and offset, and they reference adjacent memory.
 static MachineMemOperand *combineKnownAdjacentMMOs(MachineFunction &MF,
----------------
If this comment was true ("A and B are identical except for size and offset") then your patch would not be necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120370/new/

https://reviews.llvm.org/D120370



More information about the llvm-commits mailing list