[PATCH] D119233: [sancov][sanitizer-common] Correct sanitizer coverage point
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 22 20:38:27 PST 2022
MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/tools/sancov/sancov.cpp:697
return (PC - 3) & (~1);
- if (TheTriple.isMIPS())
+ if (TheTriple.isMIPS() || TheTriple.isSparc())
return PC - 8;
----------------
Drop this unrelated change.
@ro can decide what to do with isSparc. There are three places to update if `- 8` is wrong:
3de5322b5f719d9414423d4237a6533fe43cd7f8
fc0bd3c2cee929ffbd75b5cca486f4c77f7d5c59
1ec9dd3aae0b8c90a91f845ad629ef7d199986c0
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119233/new/
https://reviews.llvm.org/D119233
More information about the llvm-commits
mailing list