[PATCH] D108707: [SampleFDO] Set ProfileIsFS bit properly in extbinary format from the internal option
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 22 20:31:51 PST 2022
MaskRay added inline comments.
================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:254
ProfileIsFS = ProfileIsFSDisciminator;
+ FunctionSamples::ProfileIsFS = ProfileIsFS;
for (; !LineIt.is_at_eof(); ++LineIt) {
----------------
Writes to the static data member `ProfileIsFS` is racy: ThinLTO may creates multiple `InProcessThinBackend` instances and backends may run the code concurrently.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108707/new/
https://reviews.llvm.org/D108707
More information about the llvm-commits
mailing list