[PATCH] D120365: [WebAssembly] Fixed AsmPrinter not emitting .functype for intrinsics

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/MC/WebAssembly/extern-functype-intrinsic.ll:42
+!4 = !{!"omnipotent char", !5, i64 0}
+!5 = !{!"Simple C/C++ TBAA"}
+
----------------
I think you can remove all the attributes here?


================
Comment at: llvm/test/MC/WebAssembly/extern-functype-intrinsic.ll:48
+; CHECK-NEXT:         .file   "test.c"
+; CHECK-NEXT:         .functype       memset (i32, i32, i32) -> (i32)
+; CHECK-NEXT:         .functype       g () -> (i32)
----------------
Maybe its enough to simply check for this line?    Presumably a lot of the test is verified by the lack of failed verification? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120365/new/

https://reviews.llvm.org/D120365