[PATCH] D120357: [llvm-nm][refactor] add helper function to print out the object file name, archive name, architecture name
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 22 14:44:40 PST 2022
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1851
- if (ExportSymbols)
+static void printObjectNamesInfo(StringRef ArchiveName = {},
+ StringRef ArchitectureName = {},
----------------
The default arguments are unused
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1853
+ StringRef ArchitectureName = {},
+ StringRef OjectFileName = {}) {
+ outs() << "\n";
----------------
================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:1860
+ if (!ArchitectureName.empty()) {
+ outs() << " (for architecture " << ArchitectureName << ")";
+ }
----------------
remove braces for single-line simple statements
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120357/new/
https://reviews.llvm.org/D120357
More information about the llvm-commits
mailing list