[PATCH] D111437: [SystemZ/z/OS] Implement GOFF writer for empty files

[Kai Nacke via Phabricator via llvm-commits]

Kai marked 6 inline comments as done.
Kai added a comment.

Thanks for the review!



================
Comment at: llvm/lib/MC/GOFFObjectWriter.cpp:92
+
+  /// Signals begin of new record.
+  bool NewLogicalRecord;
----------------
jhenderson wrote:
> "begin" is a verb. You want "start" or "beginning".
Sorry, my fault. In German, both words can be used as verb or noun.


================
Comment at: llvm/lib/MC/GOFFObjectWriter.cpp:176
+  if (Remains) {
+#ifndef NDEBUG
+    assert(Remains == Gap && "Wrong size of fill gap");
----------------
jhenderson wrote:
> I don't think you need the NDEBUG check here? Isn't that within the assert macro?
Yes, agree, the `#ifndef` is not necessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111437/new/

https://reviews.llvm.org/D111437