[PATCH] D120327: compiler-rt: Add udivmodei5 to builtins and add bitint library

[Jacob Lifshay via Phabricator via llvm-commits]

programmerjake requested changes to this revision.
programmerjake added a comment.
This revision now requires changes to proceed.

As far as I can tell, this code seems to assume it's running on a little-endian system. I think it needs to correctly handle what happens when bigints are stored in the other endian (where the first word is the most-significant).

Also, the division code seems to assume that the most-significant word is always non-zero or the whole value is zero, which would allow it to use the number of words as a proxy for how big the value is numerically, which isn't the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120327/new/

https://reviews.llvm.org/D120327