[PATCH] D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 22 11:56:46 PST 2022


aardappel added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:185
 
+bool WebAssemblyAsmTypeCheck::getTable(SMLoc ErrorLoc, const MCInst &Inst,
+                                       wasm::ValType &Type) {
----------------
This function is almost identically copy-pasted from `getGlobal`, please look into a way of merging these two functions cleanly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120229/new/

https://reviews.llvm.org/D120229



More information about the llvm-commits mailing list