[PATCH] D107955: [ELF] Use SHF_SUNW_NODISCARD instead of SHF_GNU_RETAIN on Solaris

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/section-flags-solaris.test:28
+Sections:
+  - Name:  .os.flags.low
+    Type:  SHT_PROGBITS
----------------
align:
```
  - Name:    .os.flags.low
    Type:    SHT_PROGBITS
    ShFlags: 0x00100000
```


================
Comment at: llvm/test/tools/yaml2obj/ELF/retain-section.yaml:19
+Sections:
+  - Name:            .gnu.retain
+    Type:            SHT_PROGBITS
----------------
remove excessive padding while keep aligning.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1249
+const EnumEntry<unsigned> ElfGNUSectionFlags[] = {
+  ENUM_ENT(SHF_GNU_RETAIN,       "R"),
+};
----------------
Fix clang-format lints


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107955/new/

https://reviews.llvm.org/D107955