[PATCH] D120308: [compiler-rt][builtins] Fix CMake builtin target flag

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D120308#3337145 <https://reviews.llvm.org/D120308#3337145>, @thieta wrote:

> In D120308#3337114 <https://reviews.llvm.org/D120308#3337114>, @mstorsjo wrote:
>
>> Ok, that explains it a little. But with `LLVM_ENABLE_RUNTIMES`, it shouldn't (AFAIK) use `CMAKE_CXX_COMPILER` to build the runtimes (which indeed could be anything, MSVC or GCC), but instead should use the newly built clang - and that's where I'm surprised to see that it prefers the clang-cl frontend there too, instead of the clang one. Or does it set up compiler-rt via `LLVM_ENABLE_PROJECTS` in the second stage? That would explain it.
>
> I was curious and it took me a while to find - but it's selected here: https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/LLVMExternalProjectUtils.cmake#L168

Thanks for the effort to dig that up! The patch is even more good to go then!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120308/new/

https://reviews.llvm.org/D120308