[PATCH] D119908: [ELF] Move duplicate symbol check after input file parsing

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 22 01:48:20 PST 2022


ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lld/ELF/Driver.cpp:2436
+  // added at this point.
+  parallelForEach(makeArrayRef(objectFiles).slice(numObjsBeforeLTO),
+                  postParseObjectFile);
----------------
Maybe define `newObjectFiles` in this patch so that the lines are not immediately changed in the subsequent patch (D119909)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119908/new/

https://reviews.llvm.org/D119908



More information about the llvm-commits mailing list