[PATCH] D115953: [VPlan] Introduce recipe to build scalar steps.

[Ayal Zaks via Phabricator via llvm-commits]

Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Looks good to me, thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9219
   // to the phi section of the header block.
-  for (VPWidenIntOrFpInductionRecipe *Ind : InductionsToMove)
+  for (VPRecipeBase *Ind : InductionsToMove)
     Ind->moveBefore(*HeaderVPBB, HeaderVPBB->getFirstNonPhi());
----------------
leave this w/o change?


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1394
 
+class VPCanonicalIVPHIRecipe;
+
----------------
Define VPScalarIVStepsRecipe later to save this forward declaration of VPCanonicalIVPHIRecipe? Would also facilitate inlining of getCanonicalIV().


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:703
   void insertBefore(VPRecipeBase *InsertPos);
+  void insertBefore(VPBasicBlock &BB, iplist<VPRecipeBase>::iterator I);
 
----------------
Ayal wrote:
> Deserves a separate/additional comment?
Above comment refers to specified recipe (\p InsertPos); refer also to the \p BB and \p I interface?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115953/new/

https://reviews.llvm.org/D115953