[PATCH] D120308: [compiler-rt][builtins] Fix CMake builtin target flag

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D120308#3337100 <https://reviews.llvm.org/D120308#3337100>, @thieta wrote:

> Oh sorry - I guess it's a bit more complicated - it's a BOOTSTRAP build where the first stage is MSVC, then bootstrap defaults to pass `clang-cl` to the second stage, which I think is the recommended way to build LLVM on Windows (use clang-cl instead of clang).
>
> But the same effect can be found by doing `-DCMAKE_CXX_COMPILER=clang-cl` to my example above.

Ok, that explains it a little. But with `LLVM_ENABLE_RUNTIMES`, it shouldn't (AFAIK) use `CMAKE_CXX_COMPILER` to build the runtimes (which indeed could be anything, MSVC or GCC), but instead should use the newly built clang - and that's where I'm surprised to see that it prefers the clang-cl frontend there too, instead of the clang one. Or does it set up compiler-rt via `LLVM_ENABLE_PROJECTS` in the second stage? That would explain it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120308/new/

https://reviews.llvm.org/D120308