[PATCH] D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg

Mon Feb 21 21:12:44 PST 2022

cfang marked an inline comment as done.
cfang added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:413
-    if (funcRetrievesHostcallPtr(A)) {
-      removeAssumedBits(IMPLICIT_ARG_PTR);
       removeAssumedBits(HOSTCALL_PTR);
----------------
sameerds wrote:
> Why was this removed? Is there some other place which guarantees the same relationship?
I think the explicit call of amdgcn_implicitarg_ptr will guarantee IMPLICIT_ARG_PTR.

================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:57

-/// \returns The offset of the hostcall pointer argument from implicitarg_ptr
 unsigned getHostcallImplicitArgPosition();
----------------
sameerds wrote:
> The first letter should be capital. `\returns` is not the beginning of the sentence ... doxygen will render only the stuff that follows the keyword.
I see. Thanks for pointing out. 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119027/new/

https://reviews.llvm.org/D119027