[PATCH] D119908: [ELF] Move duplicate symbol check after input file parsing

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 20:58:51 PST 2022


MaskRay updated this revision to Diff 410439.
MaskRay added a comment.

Replace `getSpecificAllocSingleton<SymbolUnion>().Allocate(firstGlobal);` with `localSymStorage`.

1.02x as fast when linking clang
1.04x as fast when linking chrome

I plan to commit the change separately to decrease diff, but for single threading there is no observable difference for performance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119908/new/

https://reviews.llvm.org/D119908

Files:
  lld/ELF/Driver.cpp
  lld/ELF/InputFiles.cpp
  lld/ELF/InputFiles.h
  lld/ELF/InputSection.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119908.410439.patch
Type: text/x-patch
Size: 7454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220222/95adbfbb/attachment.bin>


More information about the llvm-commits mailing list