[PATCH] D120000: [1/2] TLS loads opimization (hoist)

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/TLSVariableControl.h:74
+
+class BasicBlock;
+class DominatorTree;
----------------
LuoYuanke wrote:
> I curious why not include the header file BasicBlock.h?
We prefer to include the *.h at x.cpp , this make x.h is simple. This style can easy find example in other files, for example "Scalar/GVNSink.cpp"


================
Comment at: llvm/include/llvm/Transforms/Scalar/TLSVariableControl.h:94
+
+/// Keeps track of a TLS variable candidate and its uses.
+struct TLSCandidate {
----------------
LuoYuanke wrote:
> uses -> users?
Make sense, The Use self is no problem, it means where is it used. But I name the "struct TLSUser" for its element, let me change it, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120000/new/

https://reviews.llvm.org/D120000