[PATCH] D120286: AMDGPU: Don't use unreachable on stores to unhandled address space

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 16:14:01 PST 2022


arsenm added a comment.

In D120286#3336509 <https://reviews.llvm.org/D120286#3336509>, @rampitec wrote:

> In fact not only the stores but atomics as well including atomic load. It is probably better to declare it an invalid IR. The only exception when it might make any sense to lower it as a global is the atomic load, although it is not really needed so there is no need to open this can of worms.

We at least need to produce the same error in debug vs. release, which this achieves


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120286/new/

https://reviews.llvm.org/D120286



More information about the llvm-commits mailing list