[PATCH] D120229: [WebAssembly] Update WebAssemblyAsmTypeCheck for table.get
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 21 16:12:49 PST 2022
sbc100 added a comment.
Thanks for working on this!
================
Comment at: lld/test/wasm/funcref.s:23
+# CHECK-NEXT: ReturnTypes:
+# CHECK-NEXT: - FUNCREF
----------------
I think this test probably belongs in `llvm/test/MC/WebAssembly/` since this change doesn't look like its related to the linker.
================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:200
+ case MCSymbolRefExpr::VK_WASM_GOT_TLS:
+ Type = is64 ? wasm::ValType::I64 : wasm::ValType::I32;
+ return false;
----------------
Why is this needed? We don't support tables that contain i32 or i64 values do we?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120229/new/
https://reviews.llvm.org/D120229
More information about the llvm-commits
mailing list