[PATCH] D120265: AMDGPU: Use the implicit kernargs for code object version 5

Changpeng Fang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 15:17:31 PST 2022


cfang added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16253-16254
+  const unsigned XOffset = IsCOV_5 ? 12 : 4;
+  auto *DP = IsCOV_5 ? EmitAMDGPUDispatchPtr(CGF) :
+                       EmitAMDGPUImplicitArgPtr(CGF);
   // Indexing the HSA kernel_dispatch_packet struct.
----------------
yaxunl wrote:
> Is the logic reversed?
You are right. Will correct it. Thanks


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120265/new/

https://reviews.llvm.org/D120265



More information about the llvm-commits mailing list