[PATCH] D120276: [move-function] Make test more generally by removing unneeded line.

[Florian Hahn via Phabricator via llvm-commits]

gottesmm created this revision.
gottesmm added inline comments.
fhahn published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.


================
Comment at: llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll:22
 ; CHECK: entryresume.0
-; CHECK-NEXT: %.debug
-; CHECK-NEXT: call void @llvm.dbg.declare(
----------------
This is the substance of the change. Using %.debug here and CHECK-NEXT is too sensitive to small changes in the rest of the codebase. It isn't needed here.


Otherwise this is can be sensitive in the face of changes in register names.

I also gardened the test case a little to make it look a little nicer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120276

Files:
  llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll


Index: llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll
===================================================================
--- llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll
+++ llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll
@@ -9,7 +9,7 @@
 
 ; CHECK-LABEL: define swifttailcc void @"$s10async_args14withGenericArgyyxnYalF"(%swift.context* swiftasync %0, %swift.opaque* noalias %1, %swift.type* %T){{.*}} {
 ; CHECK: call void @llvm.dbg.declare(
-; CHECK: llvm.dbg.addr
+; CHECK: call void @llvm.dbg.addr(
 ; CHECK-NOT: llvm.dbg.value
 ; CHECK-NOT: llvm.dbg.addr
 ; CHECK-NOT: llvm.dbg.declare
@@ -19,17 +19,16 @@
 
 ; CHECK-LABEL: define internal swifttailcc void @"$s10async_args14withGenericArgyyxnYalFTY0_"(i8* swiftasync %0)
 ; CHECK: entryresume.0
-; CHECK-NEXT: %.debug
-; CHECK-NEXT: call void @llvm.dbg.declare(
-; CHECK: llvm.dbg.addr
+; CHECK: call void @llvm.dbg.declare(
+; CHECK: call void @llvm.dbg.addr(
 ; CHECK: musttail call swifttailcc void @"$s10async_args10forceSplityyYaF"(%swift.context* swiftasync
 ; CHECK-NEXT: ret void
 ; CHECK-NEXT: }
 
 ; CHECK: define internal swifttailcc void @"$s10async_args14withGenericArgyyxnYalFTQ1_"(i8* swiftasync %0)
-; CHECK: llvm.dbg.declare
-; CHECK: llvm.dbg.addr
-; CHECK: llvm.dbg.value(metadata %swift.opaque** undef,
+; CHECK: call void @llvm.dbg.declare
+; CHECK: call void @llvm.dbg.addr
+; CHECK: call void @llvm.dbg.value(metadata %swift.opaque** undef,
 ; CHECK: ret void
 ; CHECK-NEXT: }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120276.410363.patch
Type: text/x-patch
Size: 1503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220221/4fcbf6eb/attachment.bin>