[PATCH] D120267: [Verifier] Restore defined-resolver verification for IFuncs

[Itay Bookstein via Phabricator via llvm-commits]

ibookstein created this revision.
ibookstein added reviewers: MaskRay, dexonsmith, erichkeane, rsmith.
Herald added a subscriber: hiraditya.
ibookstein requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Signed-off-by: Itay Bookstein <ibookstein at gmail.com>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120267

Files:
  llvm/include/llvm/IR/GlobalIFunc.h
  llvm/lib/IR/Verifier.cpp


Index: llvm/lib/IR/Verifier.cpp
===================================================================
--- llvm/lib/IR/Verifier.cpp
+++ llvm/lib/IR/Verifier.cpp
@@ -836,10 +836,15 @@
 }
 
 void Verifier::visitGlobalIFunc(const GlobalIFunc &GI) {
+  Assert(GlobalIFunc::isValidLinkage(GI.getLinkage()),
+         "IFunc should have private, internal, linkonce, weak, linkonce_odr, "
+         "weak_odr, or external linkage!", &GI);
   // Pierce through ConstantExprs and GlobalAliases and check that the resolver
-  // has a Function 
+  // is a Function definition
   const Function *Resolver = GI.getResolverFunction();
   Assert(Resolver, "IFunc must have a Function resolver", &GI);
+  Assert(!Resolver->isDeclarationForLinker(),
+         "IFunc resolver must be a definition", &GI);
 
   // Check that the immediate resolver operand (prior to any bitcasts) has the
   // correct type
Index: llvm/include/llvm/IR/GlobalIFunc.h
===================================================================
--- llvm/include/llvm/IR/GlobalIFunc.h
+++ llvm/include/llvm/IR/GlobalIFunc.h
@@ -84,6 +84,11 @@
     return FunctionType::get(IFuncValTy->getPointerTo(), false);
   }
 
+  static bool isValidLinkage(LinkageTypes L) {
+    return isExternalLinkage(L) || isLocalLinkage(L) || isWeakLinkage(L) ||
+           isLinkOnceLinkage(L);
+  }
+
   // Methods for support type inquiry through isa, cast, and dyn_cast:
   static bool classof(const Value *V) {
     return V->getValueID() == Value::GlobalIFuncVal;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120267.410346.patch
Type: text/x-patch
Size: 1500 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220221/5609c5e7/attachment.bin>