[PATCH] D119027: [AMDGPU][NFC]: Emit metadata for hidden_heap_v1 kernarg

Mon Feb 21 11:03:12 PST 2022

cfang marked 5 inline comments as done.
cfang added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributes.def:22
 AMDGPU_ATTRIBUTE(HOSTCALL_PTR, "amdgpu-no-hostcall-ptr")
+AMDGPU_ATTRIBUTE(HEAP_PTR, "amdgpu-no-heap-ptr")
 AMDGPU_ATTRIBUTE(WORKGROUP_ID_X, "amdgpu-no-workgroup-id-x")
----------------
sameerds wrote:
> cfang wrote:
> > sameerds wrote:
> > > It seems we need to document these attributes in AMDGPUUsage, which I missed for no-hostcall-ptr. 
> > > 
> > > https://llvm.org/docs/AMDGPUUsage.html#llvm-ir-attributes
> > Can you suggest the description for both no-hostcall and no-heap-ptr? Thanks.  
> How about this:
> 
> "Similar to amdgpu-no-implicitarg-ptr, except specific to the implicit kernel argument that holds the pointer to the hostcall buffer. If this attribute is absent, then the amdgpu-no-implicitarg-ptr is also removed."
> 
> I do believe the removal already happens, but it will be good to convince ourselves about that.
Agreed! Thanks for the suggestions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119027/new/

https://reviews.llvm.org/D119027