[PATCH] D120234: [ARM] Make i32 ISD::ABS Legal instead of pattern matching during isel.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D120234#3335288 <https://reviews.llvm.org/D120234#3335288>, @david-arm wrote:

> Hi @craig.topper, I'll be honest I haven't reviewed the code changes, but just looking at the tests it's not immediately obvious (to me at least!) what the benefit of this change is? Of course I could be missing something subtle here!

I don't understand it either. My goal was to remove the ABS matching code in ARMISelDAGToDAG.cpp which pre-dated the existence of the ISD::ABS node. After that I figured if the generated code for ABS using predicated RSB was better than the default expansion, then NABS should do the same thing using a different predicate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120234/new/

https://reviews.llvm.org/D120234