[PATCH] D120259: [AArch64][AsmParser] Arch directives should set implied features.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen created this revision.
sdesmalen added reviewers: dmgreen, mstorsjo, rsandifo-arm, david-arm.
Herald added subscribers: ctetreau, hiraditya, kristof.beyls.
sdesmalen requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When assembling for example an SVE instruction with the `.arch +sve2` directive,
+sve should be implied by setting +sve2, similar to what would happen if
one would pass the mattr=+sve2 flag on the command-line.

The AsmParser doesn't set the implied features, meaning that the SVE
instruction does not assemble. This patch fixes that.

Note that the same does not hold when disabling a feature. For example,
+nosve2 does not imply +nosve.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120259

Files:
  llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
  llvm/test/MC/AArch64/SVE/directive-arch.s
  llvm/test/MC/AArch64/SVE/directive-arch_extension-negative.s
  llvm/test/MC/AArch64/SVE/directive-arch_extension.s
  llvm/test/MC/AArch64/SVE/directive-cpu-negative.s
  llvm/test/MC/AArch64/SVE/directive-cpu.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120259.410327.patch
Type: text/x-patch
Size: 5083 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220221/b7124701/attachment.bin>