[PATCH] D119929: [MemCpyOpt] Check uses of found Clobber in writtenBetween.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:360
   MemoryAccess *Clobber = MSSA->getWalker()->getClobberingMemoryAccess(
       End->getDefiningAccess(), Loc);
+
----------------
nikic wrote:
> I'd move the getClobberingMemoryAccess() call into the `!isa<MemoryUse>` branch. Not much point doing it if we're going to discard it.
I reordered the checks in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119929/new/

https://reviews.llvm.org/D119929