[PATCH] D120122: [StableHashing] Hash machine basic blocks and functions

Mon Feb 21 06:56:13 PST 2022

arsenm added a comment.

In D120122#3335440 <https://reviews.llvm.org/D120122#3335440>, @foad wrote:

> In D120122#3335426 <https://reviews.llvm.org/D120122#3335426>, @arsenm wrote:
>
>> You're missing a lot of little fields that a pass could potentially change. e.g. block/function alignment, stack objects etc.
>
> Yes. The same is true of the IR level structural hashing that is used for the same purpose (D86589 <https://reviews.llvm.org/D86589>). I was hoping to start with something simple like this, and it can always be improved in the future.

Can you add a TODO for these sorts of things? I think it's too easy to not notice them here

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120122/new/

https://reviews.llvm.org/D120122