[PATCH] D118692: [llvm-objcopy][COFF] Fix section name encoding

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 06:06:02 PST 2022


mstorsjo added a comment.

In D118692#3335374 <https://reviews.llvm.org/D118692#3335374>, @svenvh wrote:

> In D118692#3335370 <https://reviews.llvm.org/D118692#3335370>, @mstorsjo wrote:
>
>> Sorry about that - if you happen to have such a build available, does this diff help?
>>
>>   diff --git a/llvm/lib/ObjCopy/CMakeLists.txt b/llvm/lib/ObjCopy/CMakeLists.txt
>>   index 1e516394c74a..ec1160e331c9 100644
>>   --- a/llvm/lib/ObjCopy/CMakeLists.txt
>>   +++ b/llvm/lib/ObjCopy/CMakeLists.txt
>>   @@ -64,6 +64,7 @@ add_llvm_component_library(LLVMObjCopy
>>      intrinsics_gen
>>   
>>      LINK_COMPONENTS
>>   +  BinaryFormat
>>      Object
>>      Support
>>      MC
>
> I have just committed this exact same patch, which did fix the shared libs build issue for me locally.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118692/new/

https://reviews.llvm.org/D118692



More information about the llvm-commits mailing list