[PATCH] D118692: [llvm-objcopy][COFF] Fix section name encoding

Mon Feb 21 05:59:38 PST 2022

mstorsjo added a comment.

In D118692#3335292 <https://reviews.llvm.org/D118692#3335292>, @RKSimon wrote:

> This is failing: https://lab.llvm.org/buildbot/#/builders/121/builds/16742
>
>   FAILED: lib/libLLVMObjCopy.so.15git 
>   : && /usr/bin/c++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-class-memaccess -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wmisleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/home/buildbots/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/./lib  -Wl,--gc-sections -shared -Wl,-soname,libLLVMObjCopy.so.15git -o lib/libLLVMObjCopy.so.15git lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/Archive.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/ObjCopy.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/ConfigManager.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/COFF/COFFObjcopy.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/COFF/Object.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/COFF/Reader.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/COFF/Writer.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/ELF/ELFObjcopy.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/ELF/Object.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/MachO/MachOObjcopy.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/MachO/MachOReader.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/MachO/MachOWriter.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/MachO/MachOLayoutBuilder.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/MachO/Object.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/wasm/Object.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/wasm/Reader.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/wasm/Writer.cpp.o lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/wasm/WasmObjcopy.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib"  lib/libLLVMObject.so.15git  lib/libLLVMMC.so.15git  lib/libLLVMSupport.so.15git  -Wl,-rpath-link,/home/buildbots/ppc64le-clang-multistage-test/clang-ppc64le-multistage/stage1/lib && :
>   lib/ObjCopy/CMakeFiles/LLVMObjCopy.dir/COFF/Writer.cpp.o: In function `llvm::objcopy::coff::COFFWriter::finalizeStringTable() [clone .localalias.6]':
>   Writer.cpp:(.text._ZN4llvm7objcopy4coff10COFFWriter19finalizeStringTableEv+0x1ec): undefined reference to `llvm::COFF::encodeSectionName(char*, unsigned long)'

Sorry about that - if you happen to have such a build available, does this diff help?

  diff --git a/llvm/lib/ObjCopy/CMakeLists.txt b/llvm/lib/ObjCopy/CMakeLists.txt
  index 1e516394c74a..ec1160e331c9 100644
  --- a/llvm/lib/ObjCopy/CMakeLists.txt
  +++ b/llvm/lib/ObjCopy/CMakeLists.txt
  @@ -64,6 +64,7 @@ add_llvm_component_library(LLVMObjCopy
     intrinsics_gen

     LINK_COMPONENTS
  +  BinaryFormat
     Object
     Support
     MC

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118692/new/

https://reviews.llvm.org/D118692