[PATCH] D120249: [objcopy][NFC] Fixing linking issue for libLLVMObjCopy

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 21 05:56:02 PST 2022


kito-cheng created this revision.
Herald added subscribers: abrachet, hiraditya, mgorny.
kito-cheng requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This issue only appear on `-DBUILD_SHARED_LIBS=On`
llvm::COFF::encodeSectionName is hold in libLLVMBinaryFormat.

llvm-project/llvm/lib/ObjCopy/COFF/Writer.cpp:138: error: undefined reference to 'llvm::COFF::encodeSectionName(char*, unsigned long)'


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120249

Files:
  llvm/lib/ObjCopy/CMakeLists.txt


Index: llvm/lib/ObjCopy/CMakeLists.txt
===================================================================
--- llvm/lib/ObjCopy/CMakeLists.txt
+++ llvm/lib/ObjCopy/CMakeLists.txt
@@ -64,6 +64,7 @@
   intrinsics_gen
 
   LINK_COMPONENTS
+  BinaryFormat
   Object
   Support
   MC


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120249.410290.patch
Type: text/x-patch
Size: 279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220221/f225766a/attachment.bin>


More information about the llvm-commits mailing list