[PATCH] D120219: [X86] Canonicalize SGT/UGT compares with constants for JCC to use SGE/UGE to reduce the number of EFLAGs reads.

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/use-cr-result-of-dom-icmp-st.ll:27
 ; CHECK-NEXT:  # %bb.1: # %if.end
+; CHECK-NEXT:    cmpq $-2, %rdx
 ; CHECK-NEXT:    movl $1, %ecx
----------------
RKSimon wrote:
> pengfei wrote:
> > Regression?
> kind of - its actually closer to the codegen we get without the -cgp-icmp-eq2icmp-st flag - as I mentioned in the summary, this flag isn't enabled anywhere afaict
> 
> I'll add an extra test run without the flag to show the diff
Sorry, didn't notice it mentioned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120219/new/

https://reviews.llvm.org/D120219