[PATCH] D118793: [COFF] Move section name encoding into BinaryFormat

Mon Feb 21 03:42:54 PST 2022

mstorsjo added a comment.

In D118793#3334920 <https://reviews.llvm.org/D118793#3334920>, @npmiller wrote:

> In D118793#3333621 <https://reviews.llvm.org/D118793#3333621>, @mstorsjo wrote:
>
>> @npmiller If you don't have commit access, I can push this patch for you. Can you provide your preferred git author line, i.e. "Real Name <email at address>"?
>
> @mstorsjo yeah I don't have commit access so that would be great, for the git author line: "Nicolas Miller <nicolas.miller at codeplay.com>", thank you!

Awesome, I'll push it in a little while after building and running tests then.

Btw, lld/COFF/Writer.cpp also has another instance of code doing the same (`OutputSection::writeHeaderTo`), and it'd be nice to refactor that to use the same shared routine now. It's probably less common to have over 10^6 bytes of string table in an executable, but it's clearly possible. It has a slightly different set of bugs (it writes the null byte into the following field if it's up to 10^7 bytes, and doesn't implement the base64 alternative at all), so it'd be good to fix the same there too.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118793/new/

https://reviews.llvm.org/D118793