[PATCH] D119918: [CMake] Rename TARGET_TRIPLE to LLVM_TARGET_TRIPLE

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 16 01:48:04 PST 2022


rovka added a comment.

Is this going to break for everyone that still passes TARGET_TRIPLE to cmake? If so, we should probably have a period where we support both.

In particular, this might break some of our buildbots <https://github.com/llvm/llvm-zorg/blob/main/buildbot/osuosl/master/config/builders.py> who explicitly set TARGET_TRIPLE. Could you send a patch to zorg cleaning that up (and maybe wait for that to go through before removing TARGET_TRIPLE completely)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119918/new/

https://reviews.llvm.org/D119918



More information about the llvm-commits mailing list