[PATCH] D120015: [RISCV] Add tests for SHFLI and UNSHFLI aliases in Zbp extension

Sun Feb 20 23:27:43 PST 2022

Jimerlife marked an inline comment as done.
Jimerlife added a comment.

In D120015#3334682 <https://reviews.llvm.org/D120015#3334682>, @craig.topper wrote:

> Why test zip8 and zip8.w with RV64, but not RV32?

I found test of zip8 in rv32zbp.ll, so I didn't add this test. But now I also add zip8/unzip8 tests in rv32zbp-intrinsic.ll.

================
Comment at: llvm/test/CodeGen/RISCV/rv64zbp-intrinsic.ll:135
+; RV64ZBP-NEXT:    ret
+  %tmp = call i32 @llvm.riscv.shfl.i32(i32 %a, i32 24)
+ ret i32 %tmp
----------------
craig.topper wrote:
> zip8.w is 8 not 24 right? I think type legalization is masking it off by adding with 0xf?
yes, zip8.w is 8. I updated this test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120015/new/

https://reviews.llvm.org/D120015