[PATCH] D120015: [RISCV] Add tests for SHFLI and UNSHFLI aliases in Zbp extension

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

Why test zip8 and zip8.w with RV64, but not RV32?



================
Comment at: llvm/test/CodeGen/RISCV/rv64zbp-intrinsic.ll:133
+; RV64ZBP:       # %bb.0:
+; RV64ZBP-NEXT:    zip8.w a0, a0
+; RV64ZBP-NEXT:    ret
----------------
zip8.w/unzip8.w isn't listed in the patch description


================
Comment at: llvm/test/CodeGen/RISCV/rv64zbp-intrinsic.ll:135
+; RV64ZBP-NEXT:    ret
+  %tmp = call i32 @llvm.riscv.shfl.i32(i32 %a, i32 24)
+ ret i32 %tmp
----------------
zip8.w is 8 not 24 right? I think type legalization is masking it off by adding with 0xf?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120015/new/

https://reviews.llvm.org/D120015