[PATCH] D120146: [VE] Split unsupported v512.32 ops

[Kazushi Marukawa via Phabricator via llvm-commits]

kaz7 added inline comments.


================
Comment at: llvm/lib/Target/VE/VEISelLowering.cpp:1684-1685
 VETargetLowering::getCustomOperationAction(SDNode &Op) const {
+  if (isPackingSupportOpcode(Op.getOpcode()))
+    return Legal;
+
----------------
Is it possible to add some comments why returning Legal to `isPackingSupportOpcode` is correct.  This function is basically returning legal in general and returning custom for special opcodes.  So, adding one more special treatment to return legal looks like strange for me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120146/new/

https://reviews.llvm.org/D120146