[PATCH] D116375: [X86] Use bit test instructions to optimize some logic atomic operations

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

In D116375#3318318 <https://reviews.llvm.org/D116375#3318318>, @craig.topper wrote:

> This breaks -O0. Fast isel consumes the And, then we fall back to SelectionDAG, but the And is gone so it triggers the fatal error.
>
> I'm uncomfortable with the cross pass requirements this approach depends on. It seems very fragile.

Thanks Craig! An alternative implementation D120199 <https://reviews.llvm.org/D120199>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116375/new/

https://reviews.llvm.org/D116375