[PATCH] D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2]

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 19 01:22:08 PST 2022


djtodoro added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6305
+  }
+  for (const auto &Op : DVIRec.Expr->expr_ops()) {
+    // Most Ops needn't be updated.
----------------
is the `Op` really const? 


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-5.ll:81-82
+
+attributes #0 = { mustprogress nofree norecurse nosync nounwind uwtable writeonly "frame-pointer"="none" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
+
+!llvm.dbg.cu = !{!0}
----------------
do we need all of these?


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/debuginfo-scev-salvage-5.ll:119-122
+!32 = !{!33, !33, i64 0}
+!33 = !{!"int", !34, i64 0}
+!34 = !{!"omnipotent char", !35, i64 0}
+!35 = !{!"Simple C++ TBAA"}
----------------
I guess we don't need the TBAA for the test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120169/new/

https://reviews.llvm.org/D120169



More information about the llvm-commits mailing list