[PATCH] D118840: [ELF] Support (TYPE=<value>) to customize the output section type

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 18 11:22:02 PST 2022


MaskRay added a comment.

In D118840#3332118 <https://reviews.llvm.org/D118840#3332118>, @nathanchance wrote:

> In D118840#3331575 <https://reviews.llvm.org/D118840#3331575>, @ardb wrote:
>
>> If the section name '.plt' is special in some way, I'd be happy to prepare a kernel patch that renames these into something more suitable.
>
> Would this suggested change replace Fangrui's existing patch?
>
> Regardless, @MaskRay, would you consider dropping this error for the time being until the kernel can be patched? At minimum, it is going to take a few weeks for the patch to land in Linus's tree and get backported to stable and I would like to avoid carrying any change in our continuous integration, as it adds additional maintenance overhead. Not to mention we are not the only continuous integration setup that tests with tip of tree LLVM so this breakage is going to be noticed by multiple parties, who won't have the ability to apply patches.

Downgraded (NOLOAD) error to warning with https://reviews.llvm.org/rGcb0a4bb5be10636aaec3ecb56ed586dee3eb0b9e

https://github.com/ClangBuiltLinux/linux/issues/1597 has more discussions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118840/new/

https://reviews.llvm.org/D118840



More information about the llvm-commits mailing list