[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

Fri Feb 18 07:13:49 PST 2022

xbolva00 added a comment.

In D93298#3332058 <https://reviews.llvm.org/D93298#3332058>, @jrtc27 wrote:

> In D93298#3332038 <https://reviews.llvm.org/D93298#3332038>, @xbolva00 wrote:
>
>>>> It appears that this is causing an assertion segfault in a rustc test over at our experimental rust + llvm at head bot:
>>
>> I dont think that patch author is required to debug this issue for "experimental rust + llvm at head" - downstream.
>>
>>>> Since I don't have a rust environment
>>
>> There is no requirement, indeed. LLVM devs are not responsible to keep ""experimental rust + llvm at head" working.
>
> They're required to assist with fixing regressions that show when compiling legitimate IR. An IR reproducer was given, so no Rust toolchain knowledge should be needed, at that point it's the LLVM dev's responsibility, and if they can't fix it in a timely manner then it should be backed out.

Then yeah, if IR is provided and is standard one, this is okay. Consider to add that IR as testcase for the fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93298/new/

https://reviews.llvm.org/D93298