[PATCH] D120094: [CallingConv] Generate isArgumentRegister() predicate via tablegen

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 18 04:57:49 PST 2022


uweigand added a comment.

This seems to add a large amount of code that may duplicate information already available elsewhere.   It's hard to say, in particular because I don't quite understand the exact semantics of the new `isCallingConvReg`.  For what registers exactly should this return true?   Those that may hold (part of) an argument or return value?  Those that hold some platform-specific value like a GOT pointer?   Those that may be clobbered by the call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120094/new/

https://reviews.llvm.org/D120094



More information about the llvm-commits mailing list