[PATCH] D120025: [AMDGPU] Return better Changed status from SILowerControlFlow
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 18 02:08:41 PST 2022
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/SILowerControlFlow.cpp:913
optimizeEndCf();
----------------
piotr wrote:
> It looks `optimizeEndCf` may also make some changes, but you detect this already earlier in the swtich statement (when checking for the presence of SI_END_CF), so it does not require any further changes, right?
Right, it won't do anything unless there was an SI_END_CF instruction in the function, which was detected earlier.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120025/new/
https://reviews.llvm.org/D120025
More information about the llvm-commits
mailing list