[PATCH] D120059: [sanitizer_common] Support Solaris < 11.4 in GetStaticTlsBoundary

Fri Feb 18 01:04:23 PST 2022

ro added a comment.

In D120059#3331363 <https://reviews.llvm.org/D120059#3331363>, @MaskRay wrote:

> 

> Glad to know what you only care about Solaris>=11.4:)

Sure: I'm keeping support in GCC since the 11.3/11.4 differences are useful in a couple of places and the effort is small.  LLVM is different, though, given that Solaris support is only slowly coming.

> It seems that D84046 <https://reviews.llvm.org/D84046> is the first compiler-rt commit with `llumos` in the description. So I think compiler-rt has never officially supported illumnos.

Seems so: even the `clang 13` in their `oi-userland` repo, which has some local patches, doesn't build `compiler-rt`.

> Perhaps we should ask them to fix things before adding workarounds to compiler-rt?

Seems like a plan: instead of me constantly worrying about breaking the build for them without a sensible way for a workaround, the ball is in their court.  I certainly don't intend to cause them problems and will continue to point out potential issues in my patches as far as I'm aware of them.

> Perhaps we can set up a milestone: they need to at least support `__illumos__` and `dlpi_tls_modid` before adding the port to compiler-rt...

Even the former would be enough as  a first step: in that case, we can use the `*addr = 0; *size = 0;` fallback (though some sort of `isOSIllumos()` would be needed in `clang` to avoid using `ld -z relax=transtls` which they lack).

As a first step, I've filed Issue #53919 so what needs to be done can be kept in one place rather than spread over several reviews.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120059/new/

https://reviews.llvm.org/D120059