[PATCH] D120103: Reland "[memprof] Extend the index prof format to include memory profiles."

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 22:11:51 PST 2022


snehasish created this revision.
Herald added subscribers: wenlei, arphaman, hiraditya, mgorny.
This revision was not accepted when it landed; it landed in state "Draft".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a4184909a8c: Reland "[memprof] Extend the index prof format to include memory profiles." (authored by snehasish).
Herald added projects: Sanitizers, LLVM.
Herald added subscribers: llvm-commits, Sanitizers.

Changed prior to commit:
  https://reviews.llvm.org/D120103?vs=409822&id=409857#toc

This reverts commit 19bdf44d850884a13a8708ccf1260fb7f4ef4eb3 <https://reviews.llvm.org/rG19bdf44d850884a13a8708ccf1260fb7f4ef4eb3>.

This patch adds support for optional memory profile information to be
included with and indexed profile. The indexed profile header adds a new
field which points to the offset of the memory profile section (if
present) in the indexed profile. For users who do not utilize this
feature the only overhead is a 64-bit offset in the header.

The memory profile section contains (1) profile metadata describing the
information recorded for each entry (2) an on-disk hashtable containing
the profile records indexed via llvm::md5(function_name). We chose to
introduce a separate hash table instead of the existing one since the
indexing for the instrumented fdo hash table is based on a CFG hash
which itself is perturbed by memprof instrumentation.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120103

Files:
  compiler-rt/include/profile/InstrProfData.inc
  llvm/include/llvm/ProfileData/InstrProf.h
  llvm/include/llvm/ProfileData/InstrProfData.inc
  llvm/include/llvm/ProfileData/InstrProfReader.h
  llvm/include/llvm/ProfileData/InstrProfWriter.h
  llvm/include/llvm/ProfileData/MemProf.h
  llvm/include/llvm/ProfileData/MemProfData.inc
  llvm/include/llvm/ProfileData/RawMemProfReader.h
  llvm/lib/ProfileData/CMakeLists.txt
  llvm/lib/ProfileData/InstrProf.cpp
  llvm/lib/ProfileData/InstrProfReader.cpp
  llvm/lib/ProfileData/InstrProfWriter.cpp
  llvm/lib/ProfileData/MemProf.cpp
  llvm/lib/ProfileData/RawMemProfReader.cpp
  llvm/test/tools/llvm-profdata/Inputs/basic.profraw
  llvm/test/tools/llvm-profdata/memprof-merge.test
  llvm/tools/llvm-profdata/llvm-profdata.cpp
  llvm/unittests/ProfileData/InstrProfTest.cpp
  llvm/unittests/ProfileData/MemProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120103.409857.patch
Type: text/x-patch
Size: 45131 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220218/362322a0/attachment-0001.bin>


More information about the llvm-commits mailing list