[PATCH] D119993: [MTE] Instrument use-after-scope for optnone functions.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 13:53:12 PST 2022


fmayer added a comment.

In D119993#3330790 <https://reviews.llvm.org/D119993#3330790>, @eugenis wrote:

> LGTM
>
> TBH I'm on the fence about whether poison-at-lifetime is an optimization vs "core functionality", but lets go with this change. The important part is not to run the analysis when the function does not have the attribute (that's what the *-pipeline tests check).

I think there should be a very high bar for disabling functionality with user-visible effects as "optimizations" because it adds lots of potential for confusion. In fact, from the perspective of the resulting code, the non-UAS code is potentially more optimized than the UAS one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119993/new/

https://reviews.llvm.org/D119993



More information about the llvm-commits mailing list