[PATCH] D120059: [sanitizer_common] Support Solaris < 11.4 in GetStaticTlsBoundary

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D120059#3330493 <https://reviews.llvm.org/D120059#3330493>, @ro wrote:

> In D120059#3330337 <https://reviews.llvm.org/D120059#3330337>, @MaskRay wrote:
>
>> D120048 <https://reviews.llvm.org/D120048> decreases the number of lines and looks good to me. But for this one, there is now more complexity... Can we just let old systems (Solaris<=11.3) use `*addr = 0; *size = 0;`?
>
> I don't care much about Solaris 11.3.  While I do have patches to make LLVM work, I almost certainly won't submit them.  However, even current day Illumos is the same, and just using D120048 <https://reviews.llvm.org/D120048> will break the build for them due to the use of `dlpi_tls_modid`.  Besides, we still have the matter of distinguishing Solaris and Illumos at build time. The current patch avoids all this.

Oh, thanks. Then perhaps adjust the code to work for Solaris 11.4 and let Illumos/Solaris 11.3 use the `*addr = 0; *size = 0;` fallback? That will have minimum code...

I hope we can get rid of `main_tls_modid = 1;` and `rt_tlsmodid`...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120059/new/

https://reviews.llvm.org/D120059