[PATCH] D119905: [X86ISelLowering] permit BlockAddressSDNode "i" constraints for PIC

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 17 10:42:28 PST 2022


nickdesaulniers added a comment.

In D119905#3327864 <https://reviews.llvm.org/D119905#3327864>, @MaskRay wrote:

> Consider placing the test in an existing `${0:l}` test, e.g. `asm-block-labels.ll`

llvm/test/CodeGen/X86/inline-asm-pic.ll seemed more appropriate (`-m32` && `-fPIC`).

Thanks for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119905/new/

https://reviews.llvm.org/D119905



More information about the llvm-commits mailing list