[PATCH] D120002: [lld] Make error handling functions opaque
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 17 10:29:43 PST 2022
MaskRay added a comment.
In D120002#3329478 <https://reviews.llvm.org/D120002#3329478>, @thakis wrote:
> …do we really care about 9kiB of code? On my system, lld is 49730704 bytes, so that's a 0.2% reduction. Having 7 more lines of code seems worse than the benefit from that win – and that win probably only happens if you build lld without LTO.
>
> But /shrug, if you feel this is a good change, lg I suppose :)
This saves instruction cache for some hot paths, though it's difficult to measure any improvement.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120002/new/
https://reviews.llvm.org/D120002
More information about the llvm-commits
mailing list